Holy shit, this looks like decompiled code that something like IDA would produce from a binary. How embarrassing.
That's actually a really good analogy.
I agree that in terms of programming excellence(tm) the Heartbound codebase isn't the best but to keep discussion fair I feel the need to highlight why this might be the case. Thor believes that coding quality shouldn't stand in the way of you making a game because there are highly rated games out there with absolutely horrific code.
And to be completely honest I think he is right on this point. An indie game shouldn't be judged based on industry best practices, its a passion project someone barely pushed past the finish line. Yeah you can judge him for claims of being such an epic hacker proceeded by creating spaghetti but that shouldn't take away from the message about (indie) games not needing top notch coding.
(Yes I am aware that there are limits to not caring about your code, in the end your game still needs to compile run on an average system, looking at you mr Yanderedev.)
If you're new to programming sure, use whatever that helps you make the thing your trying to make. The main thing for new devs is ask questions and search things before you commit to something so large, get people to take a look at your demo code before you do something like mald and commit to it for years. Even if you're not new; use all the arrays and switch cases you want. I don't really care what you subject yourself to, you do you. However, I can and will point out that retardation whenever I see it. I know what it's like to be given a codebase and having to retroactively edit, maintain, and add new things into code bases like that, it's not fun or enjoyable at all, it's actually quite painful and a huge man-hour waste. I don't wish to see anyone subject themselves to that kind of torture, yes, even a lolcalf like thor. I even went out of my way to give advice on both how it should and shouldn't be done. I could have just left the entire post as the "fun roast summary", but I didn't because I wanted to help anyone reading it. Imo, it was extraordinarily fair to a 20(+?) year games industry vet. He's honestly lucky I wasn't meaner and I really could have been. I was more specifically trying (probably should have made this more clear) that his code style was the entire reason his game has been stuck in limbo all this time. I even said "I have a feeling this is why his game is taking so long to make." That was really the whole point of the post and expounding on why I felt that way.
-
If he had used something like JSON at the start, or right after the demo was made, the game would have been finished and released already. And it's not like JSON is some magically super dev secret, even the fucking gamemaker forums have tons of posts about it and why you should use JSON, specifically for games like fartbound too. This is the kind of thing that really casts doubts on his experience level, someone with that level of experience would absolutely know about JSON or at the very least know enough to search for solutions before committing to such an array filled, switch-case atrocity. This would never be a go-to solution for someone even 2 years into programming let alone someone in the industry for 20(+?) years. Shit, my wife can write better code and that's because she's had to listen to me sperg about code by being my rubber ducky for decades, (yes im old). Programming can be osmosis-able via spoken word, given enough time. If he really was anywhere near game devs for that long, he'd have heard enough war stories to, at the very least ask questions and use google. It makes me question not only him, but bliztard as a whole. I really do feel like he's coasted his entire career and life, and never had anyone say anything bad to him or his processes because of his dad's position at bliztard. After bliztard, he's only held jobs for relatively small amounts of time, which to me proves the guy doesn't know what he's talking about and gets dunked on at work so badly that he has to change jobs. I've been around long enough to have seen the type and even hired + fired the same kind before.
-
He mentions Undertale is a gigantic switch statement and how bad that is, but then goes and does essentially the same thing. This is the problem with his statements, they are incongruent. I think he's saying things because he's heard them before but doesn't understand why they are actually said. If he understood why that kind of development is bad, he would have never written it that way in the first place. I have no issue with Undertale's code, the guy never really programmed anything before, you can't expect someone like Toby to write greatness. Again, mind you, mald/thor is the dude that keeps championing he's been in the industry for (over?) 20 years. Sure make your first game terribly, that's no issue. Hell make your first 100 games terribly, but at some point you have to try and strive for greatness, or even just slightly better, hell, strive for fuckin mediocrity. Lord knows his code is less than mediocre. Otherwise you're literally insane. My real problem is that he claims he's some industry vet while pumping out the hottest of dog water. He really shouldn't be propping himself up as a guru of anything besides furry sex models, if he didn't want to get his code torn apart by someone who knows more. If he was saying, "yeah I don't really program at all and all my code is really bad, pls don't reproduce" I'd really have no reason to trash his code and I honestly wouldn't. I mean fuck, his messaging would be so better received if he said "If I can do it while writing this trash, you can do it too" But that kind of statement wouldn't jive with the view he's trying to project onto himself and the world about his 1337 h4x0r sk!llz. The problem really is the "
hey guys i'm toootally credentialed and toootally amazing. you should listen to me because I've been around for sooo long, btw did i mention my dad and i worked for blizzard." shtick. That shit is annoying, exploitive and deserves every bit of criticism. In my opinion this kind of dual-action tom fuckery actually dilutes his whole messaging about anyone can and should make games. If only he'd have made himself out to be a fucking retard trying to make a game originally, I don't even think this thread would exist and his take on SKG wouldn't have been met with such opposition.
Theoretically, couldn't this game have been done faster with RPG Maker as just a narrative driven adventure game with a few addons and plugins? I feel like someone could slap together some 2D shit in RPG Maker and Unreal/Unity/Gadot with already coded mechanics and get it done a thousand times faster. I don't know, because, I am only learning from this whole thread.
You're more right than wrong. I don't know enough about GameMaker or RPGMaker to know for sure, but yeah his code isn't doing him any favors on that front. I know for certain I could program a game like his in a weekend using raw-c++,ue4/ue5/raw python, and I have via game-jams. Fuck, any random weekend game-jammer would and could out publish thor multiple times over. (A game jam is a friendly competition where people come together to create video games in a short amount of time, usually within a day or a weekend, sometimes weeks or months. in fact many games started off as game-jam projects then got polished and published)
SevenEleven said:
This is true, and one of the things I think is absolutely undeniably good about Thor is that he encourages people to just go out and try to make something, even if it's shite.
That said, I think he internalizes this mentality and uses it as an excuse to not fix up his hard-to-maintain code. His game has been in development for about 8 years, and is about 7 years late to its original promised release date. His awful codebase is undeniably getting in the way of adding more content, slowing development to a crawl as he gets deeper into the project. His game was crowdfunded and technically has not been fully released yet, something you can easily attribute to the difficult to maintain code. In addition to that, he also claims to be an expert with experience in the industry, despite only having showed off sloppy work. I think that absolutely warrants criticism.
For reference, his big inspiration Undertale was only in development for 32 months. A shitty codebase simply matters less to a smaller game with a shorter development cycle.
I completely agree about the encouragement sentiment. Like I said above in response to Avenue, I think that kind of messaging would be much more meaningful if he touted himself as a newbie not a professional, imo. The whole "see guys im just like you" actually goes really far. But it is a good thing, no doubt.
-
I personally don't think he's smart enough to know how to fix it himself and can't be burdened to ask people because he's too proud and has sniffed his dad's and his own farts for far too long. The dude can't even be bothered to search for solutions before he acts and commits to something. Not searching before acting upon and committing to it long term is exactly the kind of thing that's unforgivable to me while he's expounding for the 9001'th time he's a 20 year game industry vet.