Does a history of a law being repeatedly challenged despite it being repeatedly enforced ever factor in on these sorts of laws getting looked at again in the future?
Yes, or at least it happens. A lot of people challenged the constitutionality of arbitrary, unreasonable gun laws that were subsequently found to be actually unconstitutional in cases like
Heller and
McDonald. A number of legal scholars, like Eugene Volokh (whose own academic writing on the issue was ultimately cited by and adopted by SCOTUS in these cases, had criticized the Court's prior Second Amendment jurisprudence extensively.
It's more common, though, for a surprising verdict to come seemingly out of nowhere, like
Monroe v. Pape, the first actually influential case involving applying § 1983 to suits against the government for violations of constitutional rights. Before this case, the statute (enacted as part of the Reconstruction legislation and "Anti-Klan" Acts) had effectively been a dead letter, largely rejected as an avenue for relief from government abuses in cases like
Cruikshank (involving a section of the statute which criminalized conspiracy against rights), which incidentally involved the Second Amendment, alarmingly rejecting the very concept that the Constitution even guaranteed the right to bear arms, poisoning Second Amendment jurisprudence for over a century.
This case involved a massacre of black citizens in Colfax for daring to exercise their right to vote under the Reconstruction laws. To get around a conviction, SCOTUS completely made up law out of nowhere, made the amazing statement that the Second Amendment was essentially null and void and could be violated at will, and in effect, the 13th through 15th Amendments had no power whatsoever.
Until it was effectively overruled in
Heller, this nonsensical concept haunted Second Amendment jurisprudence, despite being based on an openly racist premise and despite essentially unwriting the Constitution and the laws meant to enforce it.
Clarence Thomas, often derided as an "Uncle Tom," took great pleasure in pointing out that these gun cases essentially overruled
Cruikshank after a century of garbage law.
Anyway, I have no hard opinion on this case by Kurt or how well he did, but bad law doesn't just go away and it rarely just goes away because of one case. It often takes a lot of chipping away at "established law" that is wrong before it comes down. I'm just not sure this specific law about national parks is actually wrong or, more importantly, unconstitutional. It might be a bad idea in some cases, since there are "national parks" that are extremely isolated and have dangerous wildlife and, worse, people, like national parks on the border with Mexico that suffer from illegal immigrant and even cartel activity.
I'd be willing to believe it's a Balldoguard though. Maybe working at Nick's direction. Still a few of those kicking around. It's not like the Balldoguards can uplift Nick at this point. Instead, they gotta try to drag Nick's critics down to his level (good luck with that).
I'm not really sure of the point of simping for Kurt. I don't dislike the guy but he has numerous cow traits, even if he is nowhere near as much of a cow as Nick. I think goofy pro se lolsuits are weird and funny in general.
So today, you can bring a firearm to a national park (say Big Bend or Yellowstone) depending on state laws (except federal structures like buildings), but if you get charged by a meth tweaker with a knife it's a violation of federal law to shoot him.
I'm pretty sure that whatever it says, the doctrines of necessity and self-defense would still be affirmative defenses just as they are in a murder case where you illegally possessed a gun, but clearly acted in self-defense.
I don't see how in practice they enforce that without simply ignoring centuries of case law on the subject.
I'm also pretty sure they could still pass laws regulating firearms on national property, although they would have to be able to pass constitutional scrutiny. It wouldn't just be a "rational basis" thing. For instance, the prohibition against bearing arms in courthouses is not merely reasonable but almost necessary to prevent daily shootings of judges, parties, lawyers, etc. (I'm not going to get into fedposting about whether that's a good or bad thing.)
Anyway considering the law has indeed changed since that suit, and in the direction Kurt was pushing, he may indeed have been on to something.