Cultcow EvaXephon / Yanderedev / Alex Mahan / Alexander Stuart Mahan / cannotgoogleme - Edgy weeaboo coomer with pedo tendencies and 15+ years internet history as a lolcow, now known as a disaster developer behind eternal debug build called "Yandere Simulator", confirmed groomer and dollfucker

The end of EvaXephon?


  • Total voters
    2,418
Wait, he stores the students in an array? Why? Is that a limitation of Unity? Why would you not use a hash map for that?
I don't see any problem with it, what would you gain by putting them in a hash map?
 
Wait, he stores the students in an array? Why? Is that a limitation of Unity? Why would you not use a hash map for that?
Possible. He either that or he has an array called "List", I think its a reserved word though. I'm trying to think of how he thought this makes sense, but this is bad. When I hear fags online talk about bad coding, I usually take it with salt because of how much turbo-autism I've seen. This dude is genuinely bad.

Edit: Must not matter unless you reference it
 
  • DRINK!
Reactions: SIGSEGV
I don't see any problem with it, what would you gain by putting them in a hash map?

Pulling an arbitrary student would be a little more readable. I'm guessing with an array he needs a fuckload of constants somewhere (or god forbid just accessing the array with numbers).
 
Last edited:
  • Horrifying
Reactions: SIGSEGV
I don't see any problem with it, what would you gain by putting them in a hash map?
Code quality.

Students[11] tells you nothing about what student that is. He could at least use an enum for that, but I still think that'd be stupid.


Students.get(OSANA) would be far more maintainable and readable.

But code quality is obviously not this guy's forte.
 
If this isn't the biggest middle finger to Alex I don't know what is. Especially the name, "Lovesick", an old proposed name Alex was going to rename Yandere Simulator.

The FAQ in the description also paints a damning picture, assuming they're telling the truth.

Q: "How long did it take to program everything shown in this video?"
A: Around 2 weeks. Another programmer and I are hard at work making this game optimized, great to play, and an all-out fun experience. (I'm not joking, it only took 2 weeks for all of this.)


If it really only took two weeks to make a working product like this then it speaks volumes about Alex's work ethic.
To be fair, Alex also doesn't know how to code. Even if he did, he definitely wouldn't have made as many improvements as those guys did in two weeks of course but no matter how much time you gave Alex, it would always be a buggy nigh unplayable mess.

This is definitely a kick in the balls to Alex though, would feel bad for him if he wasn't such a reprobate.
Yawn, wake me when this actually gets released.
 
Code quality.

Students[11] tells you nothing about what student that is. He could at least use an enum for that, but I still think that'd be stupid.


Students.get(OSANA) would be far more maintainable and readable.

But code quality is obviously not this guy's forte.
Its also part of the "StudentManager". I can't figure out why he would build a manager like this. I have never seen a manager used this way.
 
Code quality.

Students[11] tells you nothing about what student that is. He could at least use an enum for that, but I still think that'd be stupid.


Students.get(OSANA) would be far more maintainable and readable.

But code quality is obviously not this guy's forte.

While I agree that a getter would be more readable, using a hash map when you know exactly how many things you are storing/reading is overengineering. In fact, depending on the hashmap it might take slightly longer to retrieve students if two of them have the same hashed value.

Of course, all of this makes the most sense when using enums, which from what people have said he's not.
 
  • Informative
Reactions: Trombonista
Students.get(OSANA) would be far more maintainable and readable.
I think an array indexed by enums, like Students[ID_OSANA] or something would be fine.
Ideally it should be rare that you need to index it directly anyway.

Did anyone notice that Aaron Fritz (the tinyBuild consultant) marked his changes? Look for comments that contain [af] to find them. I'm going to run a search through all of the code once I finish downloading it.
 
Oh man, there's nearly 1000 lines of variable declarations in studentscript with one comment. My eyes hurt.

The only real comments are stuff like
Code:
// [af] Converted while loop to for loop.
the [af] makes me think they were left by the tinybuild coder or someone else with knowledge of typical programming conventions.

The thing that really kills me is there are a few places where code is commented out, with no explanation. Why is it commented out? Is it supposed to be added later? Why wasn't it removed?
 
I think an array indexed by enums, like Students[ID_OSANA] or something would be fine.
Ideally it should be rare that you need to index it directly anyway.

The main problem is really the use of magic numbers, not the data structure being used. Arrays with enums would be fine, indeed, I was wrong in saying that'd be stupid. My point is more that his use of magic values, like that horrible negative float inside the condition, shows what a poor coder this guy is.

I don't know much about this cow. Was he a professional programmer before starting to code this game?
 
the [af] makes me think they were left by the tinybuild coder or someone else with knowledge of typical programming conventions.
Yes, "AF" is Aaron Fritz.

Was he a professional programmer before starting to code this game?
I love the idea of Yandere Sim being the "Faces of Meth" of programming :lol:
 
Wait, he stores the students in an array? Why? Is that a limitation of Unity? Why would you not use a hash map for that?
Unless something's changed in newer versions of unity, then yes, unity cannot serialize most generic containers, or even most generics. IIRC List<T> is an exception to this, as are arrays. However, storing student data in an array isn't necessarily a terrible idea, though using numeric constants like 11 to specify specific students is definitely a terrible idea. I get the feeling that yandev just doesn't know what an enum is.

The reason you might want to store student data in an array is for easy iteration, so that you can apply a function across all students with basically no overhead. For this kind of purpose I'd personally prefer a sparse array of students, using GUIDs as the indices of generic students, and a small range of predefined students using enum values as their indices. Of course, unity being unity you'd need a custom container for this purpose, and so it's probably easier to just use a list or array.

TBF though this is the guy who has used strings in place of enums, so he might have done this for no better reason than that he's a dum dum.
 
Back