So they've removed any incentive to take a crafting profession, then? Because if there's nothing worth getting on any of the paths, does that just mean most people only take gathering skills? Or have the professions completely changed from Classic?
I'll preface this by saying that I started in the tail end of Wrath and quit in early BfA, so I didn't have much experience with the earliest side of the game.
That said, during pretty much the entirety of my playtime, crafting professions were more or less meaningless. The basic gear you could make while leveling was outclassed by questing gear that you'd get within the first hour or two, so there was never much of a market for it (I always sent it over to my enchanter to DE). Same with the max-level blues, maybe alright to pick up if you needed to fill out a slot but otherwise kind of worthless. If you dealt in bulk, maybe you could make some profit on the AH from people that wanted to jumpstart with a base set of gear, but when level boosts became a thing, that was less appealing since you'd get a free set of appropriate gear.
And as mentioned, there was very little endgame gear that you could craft, and it was always ridiculously expensive. The only real benefit I saw to most profs was the free boosts you'd get, like blacksmiths putting sockets in their gear or leatherworkers getting free leg enchants. It did have a drawback, though. Gathering professions would also provide a stat boost, but it wasn't as good as what the crafting professions offered, so you'd generally want double crafting if you were going to raid on that character. But going double crafting meant that you couldn't get resources yourself, which was especially painful at the start of the expansion when everything costs an arm and a leg.
Consumables were pretty much the only consistent moneymaker that I recall. Alchemists with potions and flasks, enchanters with enchants, scribes with glyphs (until those stopped being consumable), and other miscellaneous ones like leatherworkers' drums. If it was something players needed to stock up on for raids, you could probably make some coin off of it. Of course, if you were like me and your main didn't have consumables to create, you were shit out of luck. I was LW/engi on my main, and I rarely played my alts; I think drums existed back in BC, but they didn't add them to LW again until Legion IIRC.
I did still like engineering, even if it was borderline impossible to make any money with it. Pets and mounts were pretty much it for its moneymaking potential, if you spent the time and money on getting all the components; if you didn't, oh well, sucks to be you. But I mostly used it for all those gadgets and tinkers that made the game much more bearable. Rocket boots, gliders, Jeeves, Blingtron, portable wormholes...engineering had a lot of fun stuff.
Anyway, I dunno what people do nowadays with crafting. There were occasionally some good things to make, but overall I generally just stopped using my professions after I got them leveled up. I wish they would have made gathering professions more accessible; either make them all secondaries and let you pick them all up, or perhaps two crafting and one gathering. Being able to pick up resources myself on a double-crafting character might have made me craft more.