I don't actually know what this piece of code is *trying* to achieve, but I'm gonna take a guess, as a good conditional should be clear and understandable, especially when everything is custom booleans.
TL;DR if you skip the block, Dumbass has repeated conditions, a complete disregard for scope, Checks that indicate he didn't even separate out Player specific logic over generic students, and checks that are impossible to actually perform as they match earlier conditions. This thing would be a bug generating NIGHTMARE.
So;
If You Are:
Holding a suspicious weapon OR
Holding a bloody weapon OR
You aren't a teacher, and your also not the first student (I hate that these aren't mutually exclusive), and you are not a teacher (Yes, we check twice), but you are holding something and that item is suspicious, OR
You are a teacher, and your holding something that is suspicious but isn't a cleaning product. Why would cleaning product be suspicious, the fuck. OR
You are visibly covered with any amount of blood and are not also covered in paint (????) OR
You are significantly low on sanity OR
You are pickpocketing. Why would you want to do the same thing while pickpocketing as you do while holding a bloody weapon? OR
You are Attacking OR
You are Cauterizing (What the fuck is there for you to cauterize? is that an easter egg?) OR
You are Struggling (with my sanity, clearly) OR
You are Dragging something OR
You are Not ignoring minor shit, but you are also lewd (What does that even mean? Are you dressed lewd? Are you being lewd? Are you using a secret masturbation action?) OR
You are Carrying something OR
You are Fucking Medusa. God he's not going to be able to turn off the easter eggs, they've been fucking embedded into his CORE CONDITIONAL LOGIC. OR
You are Poisoning. What are you poisoning? Fuck if I know. OR
You are Pickpocketing. Hold on, didn't we just check this a few lines back? OR
You have a weapon timer. Can't do whatever this is if you killed a bitch with a clock. OR
You are holding something, and the thing that you are holding is a body part. OR
You are Not ignoring minor shit, but you are laughing, *and* you are laughing sufficiently hard. OR
You are Not ignoring minor shit, but you are currently crouching. OR
You are Not ignoring minor shit, but you are currently crawling. OR
You are trespassing OR
You are private (???) And your also evesdropping (He is intermingling game state, character state, and event state All in the same class, Holy fuck is this retarded) OR
You are a Teacher (why the fuck isn't all this stuff at least grouped together) and you haven't seen a corpse, and you are tresspassing. OR
You are a Teacher And you are Not ignoring minor shit, but you are currently Rummaging. Y'know, rummaging, like a normal high school gremlin. OR
You are Not ignoring minor shit (Again, group these fucking conditionals at least) And You have a theft timer. Once again, very unclear. OR
You are Student NUMBER ONE And you are near senpai, And you are not talking. OR
You are Evesdropping, and this is private. For fucks sake, another duplication. OR
You are not in the combat minigame practice mode, and you are fighting a delinquent, And you have chosen a path less than four (What the fuck is the combat path? Why is it just 0-3 that are fine?) And you are not in the combat minigame practice mode (Fucking again, in the same goddamn condition check too) And you are not currently being watched by the Authority. OR
You are suspicious of a bloody mop (I want to know why this is the only one that doesn't have the 'This' prefix now) and you are holding something. OR
You are holding a mop, And your mop is bloody. OR
You are suspicious of a bloody mop, And you are holding something, And that thing you are holding is a body part. This hurts me, because this condition can never be reached, due to the previous suspicious of mops condition. OR
You are holding something, and it is clothing, and it is evidence (Evidence? Of What?)
And thats it. Thats the fucking BRICK he built. And here's my guess. This block of code? Is to tell when that "your about to be spotted" thing should pop up and people should look at you. This fucking steaming mess repeats conditions, has conflicting conditions, unreachable conditions, and can't be read. It also directly crosses multiple different game states as part of the student manager system, because fuck compartmentalization. This massive, unreadable mess, to determine "Should I start getting suspicious". God forbid the conditions that follow it, to determine how much suspicion to raise, and from whom.
This fucking mess needs to be compartmentalized, cached (Because I bet you every student reviews all these conditions every goddamn frame, including the Yandere herself) and rewritten. The whole suspicious yandere state checker needs to be offloaded to a simple value on the yandere character, yes or no. Whenever the player does something that could modify that state, such as enter an off limits space, pick up an item, or interact with a character, reevaluate those conditions. You'd probably have two flags due to this concept of ignoring petty actions, but same premise.
C#:
If(
this.Yandere.IsSuspiciousSerious ||
!this.IgnoringPettyActions && this.Yandere.IsSuspiciousPetty ||
this.Yandere.NearSenpai
)
{
this.DoRaiseSuspicionThing();
}
www.youtube.com
so his Shitstarter would be successful.
