Mace Dindu
kiwifarms.net
- Joined
- Aug 23, 2024
PirateSoftware has started a gamedev QnA stream just now. Talking about his moist hair.
In this stream he does show some of the (very minor) edits he's doing to the Minecraft plugin code, but nothing impressive, mind you.
He seems to struggle with basic concepts, like taking 20 minutes to figure out why a multiplication of some random object with a double wasn't accepted as valid code (type mismatch, the compiler error even said as much).
He actually didn't even write that part, it's like that in the original code, he was probably looking for a particular constant to use.
I do think it looks pretty bad from a maintainability standpoint, he could have formatted those long lines such as (there's also automatic formatters that do this for you).
Java:
CRITICAL_STRIKE_CHANCE = new DoubleStat("CRITICAL_STRIKE_CHANCE",
Material.NETHER_STAR,
"Critical Strike Chance",
new String[] {
"Critical Strikes deal more damage.",
"In % chance."
},
new String[] {
"!miscellaneous",
"!block",
"all"
}),
CRITICAL_STRIKE_POWER = new DoubleStat("CRITICAL_STRIKE_POWER",
Material.NETHER_STAR,
"Critical Strike Power",
new String[] {
"The extra damage weapon crits deals.",
"(Stacks with default value)",
"In %."
},
new String[] {
"!miscellaneous",
"!block",
"all"
}),
The way the guy has it formatted also makes it harder to see changes in a git diff/patch, because if someone fixes a typo, you'll see the whole line changed instead of just that part.