I totally have not considered what having a Vulcan wife must be like during many daydreams.
But let me make the following pros:
-You can actually win an argument with her if you provide logical points to your side.
-No emotional manipulation.
-No "I'm not upset" when she's clearly upset and won't tell you why. A Vulcan wife will tell you when she disapproves of something. To be honest that one can be a con just as much as a pro.
-They don't lie.
-They don't cheat.
-They marry for life.
-They live a lot longer than humans so by the time you're an old man she'll look like she's in her late 30s.
-Your children are going to be raised as Vulcans, so they're gonna be pretty quiet and well behaved.
-Yeah, sure, for most of the time she won't be affectionate at all, and even if you can convince her to relieve you, the sex's gonna be absent or mechanical at best.... That is until her Pon'Far where all her emotions are unleashed and she fucks you like an animal for 24 hours.
-They don't like public display of affections and stuff like that so if you're not into that stuff then you don't have worry about it.
-Great to have around if you suffer from insomnia, that Vulcan neck pinch will put you right to bed, every time!
Live long and prosper!